Skip to content
This repository was archived by the owner on Jan 12, 2024. It is now read-only.

fix: failing builds and failing tests #23

Merged
merged 20 commits into from
Aug 23, 2021
Merged

fix: failing builds and failing tests #23

merged 20 commits into from
Aug 23, 2021

Conversation

oliveriosousa
Copy link
Contributor

@oliveriosousa oliveriosousa commented Aug 17, 2021 •
edited
Loading

  • Fixes the builds (https://v2.parceljs.org/blog/rc0/)
  • Fixes and relax tests
  • Adds test retries
  • Force use of yarn (useful for workspaces)
  • Adds CI to run the tests
  • Update dependencies

CC @hugomrdias

hugomrdias
hugomrdias suggested changes Aug 17, 2021
View reviewed changes
Copy link
Contributor

@hugomrdias hugomrdias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this have a local yarn install in each example folder?

@oliveriosousa oliveriosousa force-pushed the fix/package-json-and-import branch 3 times, most recently from c241f8b to cb0df32 Compare August 17, 2021 15:41
@oliveriosousa oliveriosousa force-pushed the fix/package-json-and-import branch 5 times, most recently from 85186b1 to 810ee58 Compare August 17, 2021 18:21
@oliveriosousa oliveriosousa force-pushed the fix/package-json-and-import branch from 810ee58 to 0052e51 Compare August 17, 2021 19:02
@oliveriosousa oliveriosousa force-pushed the fix/package-json-and-import branch 6 times, most recently from 1887984 to 1dae624 Compare August 19, 2021 20:02
@oliveriosousa oliveriosousa force-pushed the fix/package-json-and-import branch 3 times, most recently from bb81407 to 229d69e Compare August 19, 2021 21:10
@oliveriosousa oliveriosousa force-pushed the fix/package-json-and-import branch 3 times, most recently from a8564a6 to 67f603a Compare August 22, 2021 18:26
@oliveriosousa oliveriosousa force-pushed the fix/package-json-and-import branch from 67f603a to c69c92a Compare August 23, 2021 10:26
@oliveriosousa oliveriosousa merged commit e7ba1e9 into master Aug 23, 2021
oliveriosousa added a commit that referenced this pull request Aug 23, 2021
@oliveriosousa @hugomrdias
fix: migrate js-ipfs examples to this repository (#24)
915a55e 
fix: failing builds and failing tests #23

* fix: downgrade yarn engine version

Co-authored-by: Hugo Dias <hugomrdias@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hugomrdias hugomrdias hugomrdias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oliveriosousa @hugomrdias